[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH master f14-branch 1/2] Don't crash on unnamed installs (#621685)



> diff --git a/pyanaconda/upgrade.py b/pyanaconda/upgrade.py
> index bb7e994..d3386db 100644
> --- a/pyanaconda/upgrade.py
> +++ b/pyanaconda/upgrade.py
> @@ -83,7 +83,7 @@ def findRootParts(anaconda):
>          if notUpgradable and not anaconda.rootParts:
>              oldInstalls = ""
>              for info in notUpgradable:
> -                oldInstalls += " on ".join(info)
> +                oldInstalls += "%s %s on %s" % (info)
>                  oldInstalls += "\n"
>              rc = anaconda.intf.messageWindow(_("Cannot Upgrade"),
>                      _("Your current installation cannot be upgraded. This "

This has the potential to create a string that looks like "None None on
/dev/blah", right?  If so, I'd prefer to just leave off the first two
elements on info and show only the device name.

- Chris


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]