[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 2/2] Do not check size of swap partition(s) on s390 (#475358)



On 08/19/2010 01:11 AM, dcantrell redhat com wrote:
> From: David Cantrell <dcantrell redhat com>
> 
> Only warn if the user has not created a swap partition, but as long as
> they have a swap partition of some size, do not enforce a minimum size.
> ---
>  partitions.py |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/partitions.py b/partitions.py
> index f7473cc..52d0b8c 100644
> --- a/partitions.py
> +++ b/partitions.py
> @@ -1253,7 +1253,8 @@ class Partitions:
>              mem = mem + (16384 - rem)
>          mem = mem / 1024
> 
> -        if foundSwap and (swapSize < (mem - 8)) and (mem < 1024):
> +        if foundSwap and rhpl.getArch() != "s390" and \

I guess this needs to be:
if foundSwap and (not rhpl.getArch() in ['s390', 's390x']) and \

> +           (swapSize < (mem - 8)) and (mem < 1024):
>              warnings.append(_("You have allocated less swap space (%dM) than "
>                                "available RAM (%dM) on your system.  This "
>                                "could negatively impact performance.")

Steffen

Linux on System z Development

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martin Jetter
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]