[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] time for instdata to die


On 02/04/2010 03:44 PM, Chris Lumens wrote:
The problem with instdata which moving its content over to anaconda does
not fix, is that we need access to it almost everywhere. So we keep on
passing references around. Much the same happens to for example
storage, be it either in the form of passing around instdata or anaconda
because we need it, or by passing it around itself.

All 3 (and others like bootloader) have 2 things in common:
1) There is only ever one of them.
2) There __init__ methods have no arguments
    (other the references to the other 2)

I think it would be much better to untangle this whole mess by making
anaconda,, booty and storage singletons and there are likely other
candidates too.

This can certainly be addressed in a followup patch, but for the moment
I'm primarily concerned with getting rid of instdata.

<snip lots of good stuff>

Ok, getting rid of instdata before making somethings singletons is fine
by me.



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]