[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 3/7] Remove check for MD_DEVNAME from udev_device_is_md. (#562024)



/me fires up BIOS RAID box to check this does not break it...

Ack.

On 02/05/2010 08:07 AM, David Lehman wrote:
MD_DEVNAME is never set for existing md arrays. Some metadata versions
will have MD_NAME, but not all. All md arrays have MD_METADATA while
component devices do not, making it perfect for differentiating them.
---
  storage/udev.py |    3 +--
  1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/storage/udev.py b/storage/udev.py
index 4bef451..681cf24 100644
--- a/storage/udev.py
+++ b/storage/udev.py
@@ -151,8 +151,7 @@ def udev_device_is_dm(info):

  def udev_device_is_md(info):
      """ Return True if the device is a mdraid array device. """
-    return info.has_key("MD_DEVNAME") and \
-           info.has_key("MD_METADATA")
+    return info.has_key("MD_METADATA")

  def udev_device_is_cciss(info):
      """ Return True if the device is a CCISS device. """


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]