[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [f12-branch] Patches cherry-pick, libfreebl3.so/libsoftokn3.so



In the subjects below, I see 1/4 through 3/4, but no 4/4.  It's no big
deal, I'm just wondering if you missed a patch you meant to send.

> - 0001-Use-the-correct-yum-configuration-file-when-searchin.patch
> 
> This patch I proposed for rawhide/F-13/master and was accepted; the same
> problem exists on previous releases and I guess overall it has minor
> impact (only the EFI boot images are affected and get the right logos)

Looks fine.

> - 0002 and 0003 come from the master branch as well, and are part of the
> updates to NetworkManager. My attention was drawn to these patches by
> the following error messages which would occur during compose:
> 
> bash: install: cannot stat
> `/tmp/treedir.TTpv4G/install/lib/libfreebl3.so': No such file or directory
> bash: install: cannot stat
> `/tmp/treedir.TTpv4G/install/lib/libsoftokn3.so': No such file or directory
> 
> I had just a little difficulty applying these, since more then just one
> patch edited the same region of the scripts/mk-images and
> scripts/upd-instroot scripts.

Great, looks like the nss packages changed there too.

You don't really need patch #2 if you're just going to override it with
patch #3.  It looks like the only part of #2 you're keeping is:

> +usr/$LIBDIR/libnssdbm3.so

So you could just merge those into one.  There's lots of useful git
commands to help with this.

> Either way, my testing seems to have resolved the error messages perfectly.

Thanks for testing it out.  If you can combine #2 and #3, I've fine with
you going ahead and committing these - or, I'll commit them if that's
the way it's supposed to work.

- Chris


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]