[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 3/6] Log only the disks' names in PartitionDevice._setDisk.



Git is pissing me off tonight.

1) It refused, without asking, to include my summary mail because
   it had no body text.
2) I just learned that format-patch now defaults to numbered.
   There are only four patches in the set -- not six.

So, please review my four mis-numbered patches for the master branch.

Dave

On Mon, 2010-02-15 at 19:19 -0600, David Lehman wrote:
> ---
>  storage/devices.py |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/storage/devices.py b/storage/devices.py
> index eee43e2..ad13da9 100644
> --- a/storage/devices.py
> +++ b/storage/devices.py
> @@ -1403,7 +1403,7 @@ class PartitionDevice(StorageDevice):
>          Setting up a disk is not trivial.  It has the potential to change
>          the underlying object.  If necessary we must also change this object.
>          """
> -        log_method_call(self, self.name, old=self.disk, new=disk)
> +        log_method_call(self, self.name, old=self.disk.name, new=disk.name)
>          if self.disk:
>              self.disk.removeChild()
>  



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]