[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 4/4] Remove getDasdDevPort() and getDasdState() from isys.py.



Good this one is.

The check for DASD status "basic" below reminds me of
https://www.redhat.com/archives/anaconda-devel-list/2009-December/msg00168.html
Do we still check for "basic" to trigger potential dasdfmt?
If so that would still be wrong and could cause data loss.

On 02/19/2010 09:38 PM, David Cantrell wrote:
> These functions are no longer called from anywhere inside anaconda.
> ---
>  isys/isys.py |   43 -------------------------------------------
>  1 files changed, 0 insertions(+), 43 deletions(-)
> 
> diff --git a/isys/isys.py b/isys/isys.py
> index 237d3b7..152b755 100755
> --- a/isys/isys.py
> +++ b/isys/isys.py

> -# get active/ready state of a dasd device
> -# returns 0 if we're fine, 1 if not
> -def getDasdState(dev):
> -    devs = getDasdDevPort()
> -    if not devs.has_key(dev):
> -        log.warning("don't have %s in /dev/dasd/devices!" %(dev,))
> -        return 0
> -
> -    f = open("/proc/dasd/devices", "r")
> -    lines = f.readlines()
> -    f.close()
> -
> -    for line in lines:
> -        if not line.startswith(devs[dev]):
> -            continue
> -        # 2.6 seems to return basic
> -        if line.find(" basic") != -1:
> -            return 1
> -        # ... and newer 2.6 returns unformatted.  consistency!
> -        if line.find(" unformatted") != -1:
> -            return 1
> -
> -    return 0

Steffen

Linux on System z Development

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martin Jetter
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]