[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] devkit-disks has been replaced with udisks



On Thu, 2010-02-25 at 11:01 -0500, Chris Lumens wrote:
> > -if [ -x /usr/bin/devkit-disks ]; then
> > -    /usr/bin/devkit-disks --inhibit -- /usr/bin/hal-lock --interface org.freedesktop.Hal.Device.Storage --exclusive --run "$ANACONDA $*"
> > +if [ -x /usr/bin/udisks ]; then
> > +    /usr/bin/udisks --inhibit -- /usr/bin/hal-lock --interface org.freedesktop.Hal.Device.Storage --exclusive --run "$ANACONDA $*"
> >  elif [ -x /usr/bin/hal-lock -a -e /var/lock/subsys/haldaemon ]; then
> >      /usr/bin/hal-lock --interface org.freedesktop.Hal.Device.Storage --exclusive --run "$ANACONDA $*"
> >  else
> 
> Does hal-lock still exist?  For that matter, does org.freedesktop.Hal.* ?
> 

hal-lock does.  I noticed that we don't even check for haldaemon running
in the first test, but we do in the second test.  Furthermore, the one
issue we were chasing seems to be uneffected by the udisks change, and
in fact may be /hurt/ by the udisks change, so lets hold off on
committing this right now.  We should be aware that something needs to
be done here, but we probably need to drag in davidz and figure out what
we're trying to prevent from happening and the right way to do that with
udisks.

-- 
Jesse Keating
Fedora -- FreedomĀ² is a feature!
identi.ca: http://identi.ca/jkeating

Attachment: signature.asc
Description: This is a digitally signed message part


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]