[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 1/2] Ignore probably-spurious disklabels on unpartitionable devices. (#567832)



On Fri, 2010-02-26 at 19:56 +0100, Hans de Goede wrote:
> Hi,
> 
> On 02/26/2010 05:26 PM, David Lehman wrote:
> > ---
> >   storage/devicetree.py |    6 +++++-
> >   1 files changed, 5 insertions(+), 1 deletions(-)
> >
> > diff --git a/storage/devicetree.py b/storage/devicetree.py
> > index 386d23f..e0892d9 100644
> > --- a/storage/devicetree.py
> > +++ b/storage/devicetree.py
> > @@ -1303,7 +1303,11 @@ class DeviceTree(object):
> >               except InvalidDiskLabelError:
> >                   pass
> >               else:
> > -                device.format = format
> > +                if format.partitions:
> > +                    # parted's checks for disklabel presence are less than
> > +                    # rigorous, so we will assume that detected disklabels
> > +                    # with no partitions are spurious
> > +                    device.format = format
> >               return
> >
> >           # if the disk contains protected partitions we will not wipe the
> 
> Erm won't this mean that we will pop up a "Drive foo needs to be initialized warning"
> when there is a valid but empty disklabel ?

No, this is inside the "if not device.partitionable:" clause.

Dave

> 
> Regards,
> 
> Hans
> 
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list redhat com
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]