[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 1/6] Add readvars.c for parsing command line args and shell vars.

On Thu, 22 Jul 2010, Brian C. Lane wrote:

On 07/22/2010 02:15 PM, David Cantrell wrote:
Add functions to help simplify parsing of command line arguments as well
as files containing shell-style variables.  These functions will parse
strings where values either stand alone or are of the key=value format.
The idea is to reduce the code surrounding /proc/cmdline handling as
well as add in support for easy parsing of files containing shell
variables (e.g., ifcfg files).

I think the GError's need to be dealt with when returned. At the least
free'd up to prevent memory leaks.

Done.  If we have an error set, I'm passing it through to logMessage(), then
free'ing the GError.  I've got to wrap the g_error_free() calls in checks to
see if e is NULL, otherwise we get glib assertion spew on stdout.

Updated patch coming in next series.

David Cantrell <dcantrell redhat com>
Red Hat / Honolulu, HI

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]