[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH f14-branch master] Take into account hidden disks (#583906)



Hi,

On 10/15/2010 06:44 PM, Brian C. Lane wrote:
NOTE: I am unsure if there is any fallout from filtering hidden disks here.
NOTE: This is for a F14 Blocker

disks are used later after filtering for hidden, this will prevent
tracebacks when only hidden disks are present.

This look correct to me. hidden formats are either raid or multipath
members. If those are present a raid-set (which in this case counts
as a disk as we're talking firmware raid here not regulat mdraid) or
a multipath disk (rather then a member) should also be present. If not
then indeed we have no usable disks.

Ack.

Regards,

Hans

---
  pyanaconda/storage/__init__.py |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/pyanaconda/storage/__init__.py b/pyanaconda/storage/__init__.py
index c92b76d..48e1be4 100644
--- a/pyanaconda/storage/__init__.py
+++ b/pyanaconda/storage/__init__.py
@@ -116,7 +116,7 @@ def storageInitialize(anaconda):
      else:
          storage.reset()

-    if not storage.disks:
+    if not filter(lambda d: not d.format.hidden, storage.disks):
          rc = anaconda.intf.messageWindow(_("No disks found"),
                  _("No usable disks have been found."),
                  type="custom",


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]