[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 2/2] If there are any troubles reading the treeinfo file, return no addons.



Hi Chris,

thanks for fixing this. One comment for this patch:

On 10/21/2010 06:53 PM, Chris Lumens wrote:
+        try:
+            ConfigParser.read(c, treeinfo)
+            variant = c.get("general", "variant")
+        except:
+            return retval

We should get rid of all except: clauses without any exception, otherwise this code will sustain even SystemExit or KeyboardInterrupt. I suggest:

        except Exception as e:
	    log.info("failed to parse treeinfo file: %s" % e)
            return retval

or something.

Ales


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]