[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 1/3] Create Size class for specifying device and fs sizes.



> +class Size:

You need to inherit from object, since you use a property later.

Overall this is off to a really good start, but I'd like the class to
act more like a number.  That is, I'd like to see all the __lt__,
__eq__, __add__, etc. methods added.  I bet that would get rid of a lot
of silly stuff we're doing right now.

- Chris


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]