[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 1/2 rhel5-branch f14-branch master] Add noeject support to loader2 (#477887)



On Tue, Sep 07, 2010 at 10:10:31AM -0400, Chris Lumens wrote:
> > Ack in general.
> > 
> > You can optionally define a  helper function somewhere, something
> > like eject_cdrom_if(flags) and that will check the flag itself.
> > Given it's rhel5 anyway and it's loader anyway I do not insist at
> > all.
> 
> Or just have ejectCdrom do the flag check.

Yeah, I didn't do that because it didn't cover all the cases. Seems more
clear to keep it out of the eject function.

-- 
Brian C. Lane / Anaconda Team
Port Orchard, WA (PST8PDT)

Attachment: pgpJmzkbIknF2.pgp
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]