[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] Limit progress bar amount to 1.0



On Thu, Sep 23, 2010 at 01:14:45PM -0400, Chris Lumens wrote:
> > diff --git a/pyanaconda/gui.py b/pyanaconda/gui.py
> > index ebd0085..f6ce592 100755
> > --- a/pyanaconda/gui.py
> > +++ b/pyanaconda/gui.py
> > @@ -478,6 +478,8 @@ class ProgressWindow:
> >              delta -= 0.05
> >  
> >      def set (self, amount):
> > +        amount = min(amount, self.total)
> > +
> >          # only update widget if we've changed by 5% or our timeout has
> >          # expired
> >          curval = self.progress.get_fraction()
> 
> I like this better than the first one.  What's the behavior you are
> seeing without it?
> 

These lines show up in the logs:

18:27:39,123 WARN anaconda:
/usr/lib64/python2.7/site-packages/pyanaconda/gui.py:491: GtkWarning:
IA__gtk_progress_set_percentage: assertion `percentage >= 0 &&
percentage <= 1.0' failed
  self.progress.set_fraction (newval)

They seem to be harmless as far as functionality goes, but I got tired
of seeing them :)

-- 
Brian C. Lane / Anaconda Team
Port Orchard, WA (PST8PDT)

Attachment: pgphj7xK5inOJ.pgp
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]