[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 1/2] variable 'i' ununsed on s390(x)



On 08/01/2011 05:33 AM, Dan Horák wrote:
Variable 'i' is not used on s390(x) causing a build failure with -Werror.
---
  loader/loader.c |   10 +++++++---
  1 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/loader/loader.c b/loader/loader.c
index 90f1ce6..b072745 100644
--- a/loader/loader.c
+++ b/loader/loader.c
@@ -1919,7 +1919,7 @@ static void loadScsiDhModules(void)
  }

  int main(int argc, char ** argv) {
-    int i, rc;
+    int rc;
      int isDevelMode = 0;

      char * arg;
@@ -2166,8 +2166,12 @@ int main(int argc, char ** argv) {

      /* Disable all network interfaces in NetworkManager by default */
  #if !defined(__s390__)&&  !defined(__s390x__)
-    if ((i = writeDisabledNetInfo()) != 0) {
-        logMessage(ERROR, "writeDisabledNetInfo failure: %d", i);
+    {
+        int i;
+
+        if ((i = writeDisabledNetInfo()) != 0) {
+            logMessage(ERROR, "writeDisabledNetInfo failure: %d", i);
+        }
      }
  #endif


Looks fine, applying to master.

--
David Cantrell <dcantrell redhat com>
Supervisor, Installer Engineering Team
Red Hat, Inc. | Westford, MA | EST5EDT


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]