[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] Set EFI mountpoint when using existing partition (#727933)



ACK, but with one warning.

> diff --git a/pyanaconda/bootloader.py b/pyanaconda/bootloader.py
> index ed67356..f9fa873 100644
> --- a/pyanaconda/bootloader.py
> +++ b/pyanaconda/bootloader.py
> @@ -537,6 +537,12 @@ class BootLoader(object):
>              self.warnings = []
>              return valid
>  
> +        if os.path.exists("/dev/live") and \
> +           os.path.realpath("/dev/live") == device.path:
> +            self.errors.append(_("The live device cannot be used as the %s")
> +                               % description)
> +            valid = False
> +
>          if not self._device_type_match(device, constraint["device_types"]):
>              self.errors.append(_("The %s cannot be of type %s")
>                                 % (description, device.type))

This part (both what you added and what was already there) is going to
be hell for translators, I think.  At this point when we're trying to
get the alpha out, it's probably not worth going back and redoing.  But,
it should definitely get looked at for later on.

- Chris


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]