[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] The script sections should operate on an AnacondaKSScript instance (#728468).




--

  Martin Gracik

----- Original Message -----
> > > +from pykickstart.sections import *
> >
> > Why do you use import * so much?
> > Otherwise everything looks good.
> 
> Because I want to import everything from pykickstart.sections.

I understand what you want to achieve. But you also import * from constants, and all these * imports are cluttering the namespace, and then it's hard to see right away what names come from what modules.

> 
> - Chris
> 
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list redhat com
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]