[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH 3/3] Carry rdloaddriver= parameters through to the boot loader config.

On 08/11/2011 05:26 AM, Radek Vykydal wrote:
On 08/11/2011 02:05 AM, Brian C. Lane wrote:
On Wed, Aug 10, 2011 at 03:54:04PM -0400, David Cantrell wrote:
On 08/10/2011 03:48 PM, Chris Lumens wrote:

I don't really like this, but I think it will be okay. We don't appear
to allow for multiple instances of a command line option anywhere else
in anaconda, so you shouldn't be breaking existing behavior by using a
set when that comes up.
I'll wait to hear from the rest of the team too. I'm not too
worried about it, but tend to be thinking about this change the same
way you are.
rdloaddriver supports comma separated modules so I don't see any need to
support multiple instances of it -- especially since that will encourage
users to think other commands could do the same.

+1. The only things that I can think of as reasons for complicating
boot options handling is the comfort of adding a module with another
instance of the option, or dracut allowing the same, but I am not
sure it is worth it. Or are there any others?

Yeah, I think I'm going to go with the more simple approach. The reason I was supporting multiple rdloaddriver= parameters is because dracut does and I was aiming for support like dracut. But yeah, there's really no point in our case. So long as we at least support rdloaddriver=, we're good.

New patches coming up.  Thanks for the feedback.

David Cantrell <dcantrell redhat com>
Supervisor, Installer Engineering Team
Red Hat, Inc. | Westford, MA | EST5EDT

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]