[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH V2] add multiboot support for tboot



> +class MultibootLinuxBootLoaderImage(LinuxBootLoaderImage):
> +    def __init__(self, device=None, label=None, short=None, version=None,
> +                 multiboot=None, mbargs=None, args=None):
> +        super(MultibootLinuxBootLoaderImage, self).__init__(
> +                                                    device=device, label=label,
> +                                                    short=short, version=version)
> +        self._multiboot = multiboot      # filename string
> +        self._mbargs = mbargs
> +	self._args = args
> +
> +    @property
> +    def multiboot(self):
> +        return self._multiboot
> +
> +    def mbargs(self):
> +        return self._mbargs
> +
> +    def args(self):
> +        return self._args
>  
>  class BootLoader(object):
>      """TODO:

You're using mbargs and args down below in constructing the stanzas like
they are properties, but you aren't declaring them as such here.

> @@ -1905,6 +1939,8 @@ def writeSysconfigKernel(anaconda, default_kernel):
>      f.write("DEFAULTKERNEL=%s\n" % default_kernel)
>      f.close()
>  
> +def is_trusted_boot(anaconda):
> +    return anaconda.backend.ayum.isPackageInstalled(name="tboot")
>  
>  def writeBootloader(anaconda):
>      """ Write bootloader configuration to disk.

I really dislike the addition of backend.ayum here, because it's just
another place we'll have to fix up later.  However, I don't see a better
way to do it right now.

- Chris


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]