[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH rhel6-branch] Fix parsing of network kickstart command (#731274)



The patch looks good.

On 08/17/2011 02:50 PM, Radek Vykydal wrote:
From: Masahiro Matsuya<mmatsuya redhat com>

In some kickstart command orderings (e.g. "network" preceding "url"
command) network command is ignored.

A regression, patch tested.
---
  loader/kickstart.c |    1 +
  1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/loader/kickstart.c b/loader/kickstart.c
index 3007f86..0429d9d 100644
--- a/loader/kickstart.c
+++ b/loader/kickstart.c
@@ -561,6 +561,7 @@ void runKickstart(struct loaderData_s * loaderData) {
      logMessage(INFO, "setting up kickstart");
      for (cmd = ksTable; cmd->name; cmd++) {
          if (!strcmp(cmd->name, "network")) {
+            argv = NULL;
              while ((!ksGetCommand(cmd->code, argv,&argc,&argv))&&  cmd->setupData) {
                  cmd->setupData(loaderData, argc, argv);
              }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]