[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] Put nolock instead of , nolock to options if provided options are empty (#727522)



On 08/17/2011 02:52 PM, Martin Sivak wrote:
---
  pyanaconda/isys/imount.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/pyanaconda/isys/imount.c b/pyanaconda/isys/imount.c
index c1b7493..146a00b 100644
--- a/pyanaconda/isys/imount.c
+++ b/pyanaconda/isys/imount.c
@@ -99,7 +99,7 @@ int mountCommandWrapper(int mode, char *dev, char *where, char *fs,

      if (mode == IMOUNT_MODE_MOUNT) {
          if (strstr(fs, "nfs")) {
-            if (options) {
+            if (options&&  strlen(options)) { // do not append if the options are empty
                  if (asprintf(&opts, "%s,nolock", options) == -1) {
                      fprintf(stderr, "%s: %d: %s\n", __func__, __LINE__,
                              strerror(errno));

This looks reasonable.

Ales


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]