[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

RE: [PATCH] [rhel6-branch]add multiboot support for tboot



David Cantrell wrote onĀ 2011-08-17:
> On 08/17/2011 03:39 AM, Wei, Gang wrote:
>> Chris Lumens wrote on 2011-08-17:
>>>> diff --git a/booty/bootloaderInfo.py b/booty/bootloaderInfo.py
>>>> @@ -516,6 +516,14 @@ class bootloaderInfo(object):
>>>>           self._drivelist = val
>>>>       drivelist = property(_getDriveList, _setDriveList)
>>>> +    def _getTrustedBoot(self):
>>>> +        if self._trusted_boot is not None:
>>>> +            return self._trusted_boot
>>>> +        return 0

>>>>       def __init__(self, instData):
>>>>           self.args = KernelArguments(instData) self.images =
>>>>           BootImages() @@ -533,6 +541,7 @@ class
>>>>           bootloaderInfo(object): self.serial = 0 self.serialDevice =
>>>>           None self.serialOptions = None
>>>> +        self._trusted_boot = 0

>>> I'd like to see _trusted_boot set to True/False.
>>> 
>>> That's it, though.
>> 
>> I set it to 0 just to keep it with the same style as others in the same file.
> 
> I saw that, but in this case there was no real reason not to keep it a boolean.

Yes, I agree. When I saw 0/1 was used for other similar variables, I just a little bit doubt True/False was not support in the python version used in rhel6 installation image. :)

Jimmy


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]