[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH f16 beta NTH?] Default to an active network device after reboot on Fedora (ONBOOT) (#498207)

On Thu, Aug 18, 2011 at 11:11:12AM +0200, Radek Vykydal wrote:
> On 08/17/2011 06:13 PM, Brian C. Lane wrote:
> >On Wed, Aug 17, 2011 at 04:21:16PM +0200, Radek Vykydal wrote:
> >
> >>+    def setOnbootDefault(self, inst_class_id=None):
> >>+        if inst_class_id == "fedora":
> >>+            # devices activated during installation have ONBOOT=yes
> >>+            if hasActiveNetDev():
> >>+                return
> >Why do we need to make this conditional?
> >
> It corresponds to
> "If no device was activated during install (e.g. DVD install), "
> from commit message.
> If a device has been activated during installation,
> it has ONBOOT=yes and we are ok - network will go up
> after reboot.
> It also means that user has configured network during
> installation and we don't want to change his choices in any way
> (e.g. set ONBOOT=yes for another device having link).

Sorry, I was actually wondering about the inst_class_id check. It just
seems out of place to be checking that.

Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)

Attachment: pgpP9OwWM9Yx6.pgp
Description: PGP signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]