[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: anaconda.rootPath -> pyanaconda.constants.ROOT_PATH



> I removed many unnecessary instances of instRoot passing, to keep
> the changes more transparent I separated them into patches per file
> where the function is defined. It is a lot of boring patches so I
> uploaded them to github:
> 
> https://github.com/akozumpl/anaconda/commits/rootpath
> 
> If you'll want to extensively comment (I don't expect it) let me
> know and I'll send the patches to the list. I plan to merge them all
> in one or two patches before pushing.
> 
> Also unfortunately it turned out there is only very few instances
> where 'anaconda' can be removed: this is also because many times
> 'anaconda' is in the argument list of a callback (like the functions
> dispatcher dispatches to), or of a derived class which doesn't make
> use of it.

You're right, those are pretty boring patches.  A quick glance through
them looked fine to me, and if there's any problem we can let pylint
catch it.

- Chris


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]