[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH f15-branch master] If the umount in getFileFromNfs fails, log it.



On Mon, Feb 21, 2011 at 01:57:25PM -0500, Chris Lumens wrote:
> Related:  rhbz#678414
> ---
>  loader/nfsinstall.c |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/loader/nfsinstall.c b/loader/nfsinstall.c
> index ee0465d..0e8eb08 100644
> --- a/loader/nfsinstall.c
> +++ b/loader/nfsinstall.c
> @@ -396,8 +396,10 @@ int getFileFromNfs(char * url, char * dest, struct loaderData_s * loaderData) {
>      free(path);
>      if (ip) free(ip);
>  
> -    umount("/tmp/mnt");
> -    unlink("/tmp/mnt");
> +    if (umount("/tmp/mnt") == -1)
> +        logMessage(ERROR, "could not unmount /tmp/mnt in getFileFromNfs: %s", strerror(errno));
> +    else
> +        unlink("/tmp/mnt");
>  
>      return failed;
>  }
> -- 
> 1.7.1.1

Ack

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)

Attachment: pgpiSlTKjQdZQ.pgp
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]