[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH] Use /dev/.oldtmp instead of /oldtmp when moving around initrd /tmp



Hi Will,

On 02/21/2011 08:58 PM, Will Woods wrote:
      /* we want our /tmp to be tmpfs, but we also want to let people hack
       * their initrds to add things like a ks.cfg, so this has to be a little
       * tricky */
-    rename("/tmp", "/oldtmp");
+    copyDirectory("/tmp", "/dev/.oldtmp", copyErrorFn, copyErrorFn);
      mkdir("/tmp", 0755);

Shouldn't there be step that recursively removes /tmp after you've copied it, because this way the files that were in /tmp originally will stay there and the mkdir below fails (or is it what you intended)?

Or we can drop this altogether and tell people who want to tweak the initrds they need to put their stuff in /cantbelieveitsnottmp.

Al_


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]