[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH rhel5 0/4] Add blacklist= to RHEL5



On Fri, 2011-02-18 at 14:06 -1000, dcantrell redhat com wrote:
> "Brian C. Lane" <bcl redhat com> wrote:
> 
> > Here is an untested (and uncompiled) 1st pass at adding a blacklist= 
> > kernel command line feature. I'd like to know what you thing, am I 
> > on the right track here?
> >
> > I generally don't like adding global extern variables, but in this 
> > case I think it is worth it not to have to make more extensive 
> > changes in the code.
> >
> > What this does is add support for blacklist=modname on the kernel 
> > command line. It blocks loading these modules in the low level module
> > loading code, and it writes out a /etc/modprobe.d/anaconda.conf
> > blacklist file like we do in RHEL6 so that the modules remain blacklisted
> > upon reboot.
> >
> > I retain the parsed /proc/cmdline in memory so that there is no need to
> > come up with some other structure and memory management to keep track of
> > blacklisted modules.
> >
> > If this looks good I'll proceed with testing to make sure it actually
> > works.
> 
> The approach here is fine.  Code looks good.  If it tests out and works, I
> say it's fine for rhel5-branch.

FWIW, I concur.

Jon.



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]