[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [PATCH rhel6-branch] Generate repo= ks command only for repos added by user (#738577)

On 02/14/2012 05:01 PM, Chris Lumens wrote:
diff --git a/yuminstall.py b/yuminstall.py
index 890ed83..1a0db11 100644
--- a/yuminstall.py
+++ b/yuminstall.py
@@ -2016,6 +2016,11 @@ debuglevel=6
          for repo in self.ayum.repos.listEnabled():
              if repo.name == "Installation Repo":
+            if repo.name == "Red Hat Enterprise Linux":
+                continue
+            # ignore addon repos from media
+            if repo.anacondaBaseURLs[0].startswith("file://"):
+                continue

              line = "repo --name=\"%s\" " % (repo.name or repo.repoid)
Looking at yuminstall.py, I see no guarantees that an addon repo's URL
starts with "file://".  You could, however, set an "addon" attribute on
AnacondaYumRepo and check for that.

Note that I don't want to exclude all addon repos.
What you suggest was exactly one option I was considering,
but finally I decided that I want to exclude only addon repos
from media - those that make generated ks fail (the bz issue),
not e.g. addon repos enabled in task screen. Having the latter
in generated repo= makes sense to me and there could
be people relying on this behaviour). In this case new attribute
seems is overkill.

(Originally I was even considering repo.type attribute (values
'addon', 'base') to be able to handle base repos independently
of RHEL/Fedora and repo name)

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]