[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Proposal of minor LiveDVD F19 network/hostname configuration UX improvement (PATCH included)



Original request with links to user inputs is in
https://bugzilla.redhat.com/show_bug.cgi?id=963059

Proposed change aims to

- offer hostname setting in installer also in cases where
  network has been setup in Live environment automatically
  using default dhcp, and make it more prominent also for
  other cases
- give hint to use live desktop environment for network configuration
- in a way workable for F19


F18 behaviour:
- only in case where there is no network connection we display
  pre-hub (standalone) network spoke requesting (incorrectly)
  network configuration, allowing the configuration using the spoke
  (although preferred/recommended way is to use DE), and containing
  hostname entry:
  http://rvykydal.fedorapeople.org/live18standalone.png
- network spoke (NETWORK CONFIGURATION) is not displayed on summary
  hub/screen (want DE tools to be used for network configuration):
  http://rvykydal.fedorapeople.org/live18hub.png


current F19 behaviour:
- pre-hub (standalone) network spoke is never displayed (we don't require
  network connection for Live DVD install)
- network spoke (NETWORK CONFIGURATION) is not displayed as in F18


proposed behaviour:
- pre-hub (standalone) network spoke containing
  - hint to use DE tools to configure network optionally
  - entry allowing to setup hostname
  is always displayed
- network spoke (NETWORK CONFIGURATION) is not displayed as in F18
see http://rvykydal.fedorapeople.org/live_network_hostname.webm

The patch is attached.


Do you see it as an improvement acceptable for F19?
(It could use some wording/layout polishing.)


Radek
>From 8c660909006b1474fcc19c9f1814376fc89a4cd9 Mon Sep 17 00:00:00 2001
From: Radek Vykydal <rvykydal redhat com>
Date: Wed, 22 May 2013 10:28:25 +0200
Subject: [PATCH f19-branch?] Add modified standalone network spoke to LiveDVD (#963059)

The purpose is to:
- tell user to use DE tools to configure network
- allow user to set hostname

Network configuration box is removed from the spoke.
---
 pyanaconda/ui/gui/spokes/network.py | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/pyanaconda/ui/gui/spokes/network.py b/pyanaconda/ui/gui/spokes/network.py
index 432fc09..bb14cd1 100644
--- a/pyanaconda/ui/gui/spokes/network.py
+++ b/pyanaconda/ui/gui/spokes/network.py
@@ -1257,12 +1257,16 @@ class NetworkStandaloneSpoke(StandaloneSpoke):
 
     @property
     def completed(self):
-        return (not flags.can_touch_runtime_system("require network connection")
-                or len(self.network_control_box.activated_connections()) > 0)
+        return (flags.can_touch_runtime_system("require network connection")
+                and len(self.network_control_box.activated_connections()) > 0)
 
     def initialize(self):
         StandaloneSpoke.initialize(self)
         self.network_control_box.initialize()
+        if not flags.can_touch_runtime_system("recommend network configuration in DE for live install"):
+            self.builder.get_object("networkNeedLabel1").set_text(_("Network configuration of Live environment will be used for installed system. You can customize the configuration using tools of the Live environment."))
+            self.builder.get_object("vbox2").set_no_show_all(True)
+            self.builder.get_object("vbox2").hide()
 
     def refresh(self):
         StandaloneSpoke.refresh(self)
-- 
1.7.11.7


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]