[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: Grub installation. First potential Fedora killer



> >From 88d4843eda3a00b0474ecb26242c52e4f378add7 Mon Sep 17 00:00:00 2001
> From: Adam Williamson <awilliam redhat com>
> Date: Sun, 5 Jan 2014 22:57:51 -0800
> Subject: [PATCH] write a device.map and bootloader config when 'skipping'
>  grub2 install
> 
> The usual reason for skipping bootloader installation is if you want to do
> a multi-boot configuration other than one where Fedora 'takes over' boot.
> People who do this are usually going to have a much easier time if they have
> a config file - our 'official' recommendation instead of chainloading is to
> use grub2's configfile functionality, and that obviously requires the OS
> to have a config file.

I think 886502 is the bug this addresses, so you'll want to refer to
that here.  See the format we use throughout git.

> diff --git a/pyanaconda/bootloader.py b/pyanaconda/bootloader.py
> index fe62b3a..741169d 100644
> --- a/pyanaconda/bootloader.py
> +++ b/pyanaconda/bootloader.py
> @@ -1566,6 +1566,12 @@ class GRUB2(GRUB):
>      def write(self):
>          """ Write the bootloader configuration and install the bootloader. """
>          if self.skip_bootloader:
> +            """ We should write a config file at least, as the normal
> +            reason for skipping bootloader installation is to do advanced
> +            multi-boot, and it's useful to have a config file. """
> +            self.write_device_map()
> +            sync()
> +            self.write_config()
>              return
>  
>          if self.update_only:

Looks fine to me, but I am no bootloader expert.

- Chris


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]