[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

isomd5sum-1.0.12 bug report



Hello there,

I just ran the static analysis tool cppcheck over
the source code of isomd5sum-1.0.12

It said many things, including

1.

[libcheckisomd5.c:106] -> [libcheckisomd5.c:106]: (warning) Array 'buf2[512]' accessed at index 512, which is out of bounds.

Source code is

            for (p=tmpbuf; buf2[loc] != ';' && loc < 512; p++, loc++)

I suspect 

            for (p=tmpbuf; loc < 512 && buf2[loc] != ';' ; p++, loc++)

might be better code.

2.

[libcheckisomd5.c:144] -> [libcheckisomd5.c:144]: (warning) Array 'buf2[512]' accessed at index 512, which is out of bounds. 

Duplicate.

Regards

David Binderman 		 	   		  


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]