[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: On disk repos, anaconda, and Installation Source



Thanks!

I'll kick up a patch to change the comment to match the expected behavior.

Pat

On 6/19/19 7:22 AM, jkonecny redhat com wrote:
Hello,

So about the code and treeinfo. This repository is not loaded because it is disabled on the netboot image and the code is iterating only between enabled repositories, which is the correct behavior I would say.

Yes the comment is wrong, originally it was above the ``self.set_updates_enabled(self._updates_enabled)`` line and the meaning was that all the repos there will be enabled (under some conditions) and user can adjust this by the checkbox in UI. The are of course the conditions so it's not always so or so. That comment should definitely change or the whole code should be rewritten to be more readable.

You can read the conditions if you follow the `enabled` variable in this method. In short these local repositories will be enabled if there is no installation method set and it is not automatic installation -- (in other words "Closest mirror" installation).

And no, this repositories shouldn't be loaded into the addon list right now. We can think about that in the further changes but now it is just implementation detail of the Closest mirror installation type.

Cheers,
Jirka


On Fri, 2019-06-14 at 13:58 -0500, Pat Riehecky wrote:
I noticed an unexpected behavior in Fedora 30.

The net install disk for Workstation ships with the 'fedora-cisco-openh264' repo on the media.  However, the repo is not listed under the 'Installation Source' spoke.

Should this repo be loaded into the addons list?

I suppose this is a bit of confusion based on this comment [1], vs the actual behavior where only `.treeinfo` repos that are also on disk get enabled [2]

Thoughts?

Pat


[1] https://github.com/rhinstaller/anaconda/blob/master/pyanaconda/payload/dnfpayload.py#L1144

[2] self.addons seems to be populated via __init__.py and what it finds in `.treeinfo` I think.
https://github.com/rhinstaller/anaconda/blob/master/pyanaconda/payload/dnfpayload.py#L1235

-- 
Pat Riehecky

        
Fermi National Accelerator Laboratory
www.fnal.gov

        
          
www.scientificlinux.org
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list redhat com

        
          
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

-- 
Pat Riehecky

Fermi National Accelerator Laboratory
www.fnal.gov
www.scientificlinux.org

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]