<div dir="ltr"><div>It's no longer required. Closing it now. </div>-Ryan </div><div class="gmail_extra"> <div class="gmail_quote">On Tue, Feb 13, 2018 at 7:24 PM, Erik Nelson <<a href="mailto:ernelson@redhat.com" target="_blank">ernelson@redhat.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">@Ryan, I merged Shawn's PR. You have another PR that looked like a WIP for release-1.0? Is your PR required anymore now that Shawns is merged, or is it doing something else? <div class="HOEnZb"><div class="h5"> On Tue, Feb 13, 2018 at 7:19 PM, Ryan Hallisey <<a href="mailto:rhallise@redhat.com">rhallise@redhat.com</a>> wrote: > Thanks Shawn! I'm glad we got that working again. > >> Also I noticed that we no longer need the dist upgrade on each run of CI. >> > The kubernetes job we have didn't need the dist upgrade. Something must've > changed upstream, but I wasn't sure if it propagated to the latest openshift > release. Looks like it did. I'll post PRs dropping the dist upgrade. > > Thanks, > -Ryan > > On Tue, Feb 13, 2018 at 5:29 PM, Shawn Hurley <<a href="mailto:shurley@redhat.com">shurley@redhat.com</a>> wrote: >> >> Forgot the PR link: >> <a href="https://github.com/openshift/ansible-service-broker/pull/760" rel="noreferrer" target="_blank">https://github.com/openshift/ansible-service-broker/pull/760</a> >> >> Sorry >> >> - Shawn >> >> On Feb 13, 2018, at 5:29 PM, Shawn Hurley <<a href="mailto:shurley@redhat.com">shurley@redhat.com</a>> wrote: >> >> Hello All, >> >> I have a small PR up that should fix the CI for release 1.0. >> >> @Ryan I borrowed some stuff from your WIP PR as well, it seems that the >> combo of the changes has fixed the problem. >> >> Also I noticed that we no longer need the dist upgrade on each run of CI. >> I think that we should also change this for master and release 1.1. I don’t >> think that we should need a bug for this fix and will post a PR tomorrow >> unless someone wants to take this issue up. >> >> Thanks, >> >> Shawn Hurley >> >> >> >> _______________________________________________ >> Ansible-service-broker mailing list >> <a href="mailto:Ansible-service-broker@redhat.com">Ansible-service-broker@redhat.com</a> >> <a href="https://www.redhat.com/mailman/listinfo/ansible-service-broker" rel="noreferrer" target="_blank">https://www.redhat.com/mailman/listinfo/ansible-service-broker</a> >> > > > _______________________________________________ > Ansible-service-broker mailing list > <a href="mailto:Ansible-service-broker@redhat.com">Ansible-service-broker@redhat.com</a> > <a href="https://www.redhat.com/mailman/listinfo/ansible-service-broker" rel="noreferrer" target="_blank">https://www.redhat.com/mailman/listinfo/ansible-service-broker</a> > </div></div></blockquote></div> </div>