<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Hello All,<div class=""><br class=""></div><div class="">I am expecting to call the generated client <a href="https://github.com/automationbroker/broker-client-go" class="">https://github.com/automationbroker/broker-client-go</a> </div><div class=""><br class=""></div><div class="">Does anyone think the name should be different? I don’t have strong opinions but the name is attempting to implicate that it is similar to the client-go but specifically for the broker. I could see maybe just client-go because it is in the automation broker repo?</div><div class=""><br class=""></div><div class="">Thanks,</div><div class=""><br class=""></div><div class="">Shawn Hurley<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Feb 20, 2018, at 2:14 PM, Ryan Hallisey <<a href="mailto:rhallise@redhat.com" class="">rhallise@redhat.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div class=""><div class="">Sounds good to me Shawn. This is a good step towards being vendorable.<br class=""><br class=""></div>Looks like the git org <a href="https://github.com/AutomationBroker" class="">https://github.com/AutomationBroker</a> already exists. Does someone here own it? It looks abandoned. Maybe we can ask git to delete it.<br class=""><br class=""></div>-Ryan<br class=""></div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Tue, Feb 20, 2018 at 2:01 PM, Shawn Hurley <span dir="ltr" class=""><<a href="mailto:shurley@redhat.com" target="_blank" class="">shurley@redhat.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word;line-break:after-white-space" class="">Yes that is correct about the venerable dependency.<div class="">An example of what this would look like is here: <a href="https://github.com/openshift-evangelists/crd-code-generation" target="_blank" class="">https://github.com/<wbr class="">openshift-evangelists/crd-<wbr class="">code-generation</a>. </div><div class=""><br class=""></div><div class="">In a nut shell the client is like every other client-go for k8s resources. it has listers/informers and the interface/impl for crud operations. </div><div class=""><br class=""></div><div class="">Thanks,</div><div class=""><br class=""></div><div class="">Shawn </div><div class=""><div class="h5"><div class=""><div class=""><br class=""><blockquote type="cite" class=""><div class="">On Feb 20, 2018, at 1:57 PM, Ryan Hallisey <<a href="mailto:rhallise@redhat.com" target="_blank" class="">rhallise@redhat.com</a>> wrote:</div><br class="m_4620638948112946103Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div class="">Would the broker-client-go be essentially a vendorable dependency like the client-go package in kubernetes? Do I understand that correctly? At a high level, what would be in the broker-client-go?<br class=""><br class=""></div>-Ryan<br class=""></div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Tue, Feb 20, 2018 at 1:43 PM, <a href="mailto:cbrookes@redhat.com" target="_blank" class="">cbrookes@redhat.com</a> <span dir="ltr" class=""><<a href="mailto:cbrookes@redhat.com" target="_blank" class="">cbrookes@redhat.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="auto" class="">I think that is a great way of doing it! We use the generators for our mobile crd types and it is working well for us. I would really like if the service catalog had taken the approach of a separate repo for the client maybe we could suggest it?<br class=""><br class=""><div id="m_4620638948112946103m_8482382357315667036AppleMailSignature" class="">Craig</div><div class=""><div class="m_4620638948112946103h5"><div class=""><br class="">On 20 Feb 2018, at 18:33, Shawn Hurley <<a href="mailto:shurley@redhat.com" target="_blank" class="">shurley@redhat.com</a>> wrote:<br class=""><br class=""></div><blockquote type="cite" class=""><div class="">Hello All,<div class=""><br class=""></div><div class="">I wanted to send out a note to make sure that everyone was ok with the approach for the k8s like client for broker CRDs.</div><div class=""><br class=""></div><div class="">I was thinking that we would create a new repo, I assume we need a new org (automationbroker or something similar), and this would contain the broker-client-go.</div><div class=""><br class=""></div><div class="">The client would be generated using the k8s generate client scripts and code. Here is a blog post about how this works for some context: <a href="https://blog.openshift.com/kubernetes-deep-dive-code-generation-customresources/" target="_blank" class="">https://blog.openshif<wbr class="">t.com/kubernetes-deep-dive-<wbr class="">code-generation-customresource<wbr class="">s/</a></div><div class=""><br class=""></div><div class="">This client then would be added to the broker through glide/dep. </div><div class=""><br class=""></div><div class="">If the above is agreeable some help/guidence on next steps for making the new repo would be appreciated.</div><div class=""><br class=""></div><div class="">Thanks,</div><div class=""><br class=""></div><div class="">Shawn Hurley</div><div class=""><br class=""></div></div></blockquote></div></div><blockquote type="cite" class=""><div class=""><span class="">______________________________<wbr class="">_________________</span><br class=""><span class="">Ansible-service-broker mailing list</span><br class=""><span class=""><a href="mailto:Ansible-service-broker@redhat.com" target="_blank" class="">Ansible-service-broker@redhat.<wbr class="">com</a></span><br class=""><span class=""><a href="https://www.redhat.com/mailman/listinfo/ansible-service-broker" target="_blank" class="">https://www.redhat.com/mailman<wbr class="">/listinfo/ansible-service-<wbr class="">broker</a></span><br class=""></div></blockquote></div><br class="">______________________________<wbr class="">_________________<br class=""> Ansible-service-broker mailing list<br class=""> <a href="mailto:Ansible-service-broker@redhat.com" target="_blank" class="">Ansible-service-broker@redhat.<wbr class="">com</a><br class=""> <a href="https://www.redhat.com/mailman/listinfo/ansible-service-broker" rel="noreferrer" target="_blank" class="">https://www.redhat.com/mailman<wbr class="">/listinfo/ansible-service-<wbr class="">broker</a><br class=""> <br class=""></blockquote></div><br class=""></div> </div></blockquote></div><br class=""></div></div></div></div></blockquote></div><br class=""></div> </div></blockquote></div><br class=""></div></body></html>