<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><div class="">> Vendor is kinda special. The approach I am highlighting would remove it from vendor and put it under the main src code. In k8s this is /staging/src/<a href="http://k8s.io/client-go" class="">k8s.io/client-go</a> as an example. Then something automated would sync the latest for that directory to a separate repo for general consumption. </div><div class=""><br class=""></div>I believe that kubernetes is attempting to move away from that model anyway. They are moving towards separate PRs from the different repos, you can see an example of how openshift is now dealing with this. <div class=""><br class=""></div><div class="">I have already done multiple PRs to bundle-lib w/ a release and then a vendor bump PR and then a PR for the changes you need.</div><div class=""><br class=""></div><div class="">I believe that this is the correct approach expecially as we move to having many consumers of the bundle lib and not just the broker, we need to make sure that changes that go into bundle-lib don’t break others.</div><div class=""><br class=""></div><div class="">Thanks,</div><div class=""><br class=""></div><div class="">Shawn </div><div class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Apr 9, 2018, at 9:57 AM, Craig Brookes <<a href="mailto:cbrookes@redhat.com" class="">cbrookes@redhat.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204); padding-left: 1ex;">I'm okay with doing a release of bundle-lib to release any features already there but I don't think you need a release in order to make follow on prs. the changes to bundle-lib could be copied into the vendor directory of the broker to pick up any changes you are needing.<br class=""><br class="">Then prs can be filed separately for bundle-lib and broker.</blockquote><div class=""><br class=""></div><div class="">Would these changes not get wiped out if you ran dep ensure? Do we do this before a release or during a build? If running dep ensure would cause problems this approach seems a little scary particularly for reproducible builds as what is in vendor would not be reflected by what is in the lock file. I probably need to go check it out as I am not 100% on this.<br class=""><br class=""><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204); padding-left: 1ex;"><br class="">-1 to putting the lib in mainline (it's already in vendor)</blockquote><div class=""><br class=""></div><div class="">Vendor is kinda special. The approach I am highlighting would remove it from vendor and put it under the main src code. In k8s this is /staging/src/<a href="http://k8s.io/client-go" class="">k8s.io/client-go</a><span class="Apple-converted-space"> </span>as an example. Then something automated would sync the latest for that directory to a separate repo for general consumption.<span class="Apple-converted-space"> </span><br class=""></div></div></div><div class="gmail_extra" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><br class=""><div class="gmail_quote">On Mon, Apr 9, 2018 at 2:46 PM, jesus m. rodriguez<span class="Apple-converted-space"> </span><span dir="ltr" class=""><<a href="mailto:jesusr@redhat.com" target="_blank" class="">jesusr@redhat.com</a>></span><span class="Apple-converted-space"> </span>wrote:<br class=""><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204); padding-left: 1ex;">I'm okay with doing a release of bundle-lib to release any features already there but I don't think you need a release in order to make follow on prs. the changes to bundle-lib could be copied into the vendor directory of the broker to pick up any changes you are needing.<br class=""><br class="">Then prs can be filed separately for bundle-lib and broker.<br class=""><br class="">-1 to putting the lib in mainline (it's already in vendor)<br class=""><br class="">Sincerely,<br class="">Jesus<br class=""><br class=""><br class="">Sent from Blue <br class=""><div class=""><div class="h5"><br class="">On Apr 9, 2018, 9:41 AM, at 9:41 AM, Craig Brookes <<a href="mailto:cbrookes@redhat.com" class="">cbrookes@redhat.com</a>> wrote:<br class="">>While looking at this bug<br class="">><a href="https://bugzilla.redhat.com/show_bug.cgi?id=1564542" rel="noreferrer" target="_blank" class="">https://bugzilla.redhat.com/<wbr class="">show_bug.cgi?id=1564542</a>, I realized that I<br class="">>needed to create a PR against the bundle-lib before I could fix it in<br class="">>the<br class="">>broker.<br class="">><br class="">>However I will need a new release in order to pick it up. Wondering<br class="">>what<br class="">>folks think to doing a release of the lib?<br class="">><br class="">>It raises an interesting conundrum for contributors. As most of the<br class="">>logic<br class="">>is in this lib, it seems you will often need a release of the lib<br class="">>before<br class="">>you can create the follow on PR in the broker.<br class="">><br class="">>Something that the Kubernetes repo has done is have separate repos for<br class="">>things like the client-go but have the actual source back in the main<br class="">>repo<br class="">>and sync to the external repo regularly. Wondering if there was any<br class="">>interest in an approach like this.<br class="">><br class="">>Making it as simple as possible to expand the broker while still<br class="">>providing<br class="">>a valuable library seems like an ideal sweet spot to me.<br class="">><br class="">>--<br class="">>Craig Brookes<br class="">>RHMAP<br class="">>@maleck13 Github<br class="">><br class="">><br class=""></div></div>>-----------------------------<wbr class="">------------------------------<wbr class="">-------------<br class="">><br class="">>_____________________________<wbr class="">__________________<br class="">>Ansible-service-broker mailing list<br class="">><a href="mailto:Ansible-service-broker@redhat.com" class="">Ansible-service-broker@<wbr class="">redhat.com</a><br class="">><a href="https://www.redhat.com/mailman/listinfo/ansible-service-broker" rel="noreferrer" target="_blank" class="">https://www.redhat.com/<wbr class="">mailman/listinfo/ansible-<wbr class="">service-broker</a><br class=""><br class=""></blockquote></div><br class=""><br clear="all" class=""><br class="">--<span class="Apple-converted-space"> </span><br class=""><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr" class="">Craig Brookes<div class="">RHMAP </div><div class="">@maleck13 Github</div></div></div></div><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">_______________________________________________</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">Ansible-service-broker mailing list</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><a href="mailto:Ansible-service-broker@redhat.com" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class="">Ansible-service-broker@redhat.com</a><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><a href="https://www.redhat.com/mailman/listinfo/ansible-service-broker" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class="">https://www.redhat.com/mailman/listinfo/ansible-service-broker</a></div></blockquote></div><br class=""></div></body></html>