[augeas-devel] [PATCH] Write last created node in /augeas/tree/last_created for tree_create and tree_insert

David Lutterkort dlutter at redhat.com
Mon Aug 11 18:44:38 UTC 2008


On Mon, 2008-08-11 at 12:22 +0200, Raphaël Pinson wrote:
> If I change tree_insert to take a struct path *path instead of a const
> char *path, then there is a problem with tree_insert_glue in
> builtin.c, because it can't provide a struct path to tree_insert since
> struct path is a structure specific to augeas.c. On the other hand, if
> I move struct path to internal.h, then I still have to move make_path
> aswell...

There's two things you can do:

      * Declare struct path and make_path to internal.h, so that they
        can be called from tree_insert_glue
      * Leave the prototype for tree_insert the way it is, but change
        its implementation to just call make_path, and move the rest of
        its body into a new function tree_insert_path that takes a
        struct path

I think either is fine, though I have a slight preference for the second
option.

David





More information about the augeas-devel mailing list