[augeas-devel] [PATCH 2 of 7] Rewrite inifile.aug entirely

[David Lutterkort]

On Thu, 2008-08-14 at 17:52 +0200, Raphael Pinson wrote:
> # HG changeset patch
> # User Raphael Pinson <raphink at gmail.com>
> # Date 1218728917 -7200
> # Node ID 2d254500331759e7334d28d5af680e4b360da724
> # Parent  9dfd488a44716a108971f084228d36dd1d682476
> Rewrite inifile.aug entirely
 
I like where this is going; one suggestion:

> +let record_noempty (title:lens) (entry:lens)
> +                       = [ title
> +		       . entry* ]
> +let record (title:lens) (entry:lens)
> +                       = record_noempty title ( entry | empty )
> +let record_re          = ( /[^]\n\/]+/ - /#comment/ ) 
> +let record_label_re    = /[^]\n]+/

What do you think about renaming all the lenses that have 'record' in
their name to 'section...', since that's what they are dealing with ? If
you agree, don't worry about making that change now ... I can do that
easily after your patch series has been committed, otherwise the patches
will get too confusing.

David