[augeas-devel] [PATCH 4 of 7] Rewrite php.aug on new inifile.aug

David Lutterkort dlutter at redhat.com
Fri Aug 15 00:40:52 UTC 2008


On Thu, 2008-08-14 at 17:52 +0200, Raphael Pinson wrote:
> # HG changeset patch
> # User Raphael Pinson <raphink at gmail.com>
> # Date 1218728952 -7200
> # Node ID b3d373af10fdb0150400ec084c4d51b60031ef65
> # Parent  eeabbccba76be48bd0b338d625bf434e795ae77c
> Rewrite php.aug on new inifile.aug

Looks good, except for

> +let entry_re = ( /[A-Za-z][A-Za-z0-9\._-]+/ - /#comment/ - /section/ )

This allows literal '\' in the names of entries. In POSIX extended
regexps, '\' does not escape inside a '[..]'; you do not need to escape
'.' in a character class - '[.]' matches only a literal dot.

You can verify that with "echo a..b | sed -r -e 's/[.]/X/g'"

>  let filter = (incl "/etc/php*/*/php.ini")
>               . Util.stdexcl

Where are the php.ini files on Debian/Ubuntu ? Is there one directory
for each module ?

On Fedora/RHEL, they are in /etc/php.ini and /etc/php.d/*.ini - I'll add
that to the filter when I commit. There isn't any harm in listing files
in the filter that won't exist.

David





More information about the augeas-devel mailing list