[augeas-devel] Re: [PATCH] phpvars lens

[Free Ekanayaka]

Hi David,

|--==> On Mon, 22 Dec 2008 10:55:08 -0800, David Lutterkort <lutter at redhat.com> said:

  DL> On Sat, 2008-12-20 at 11:32 +0000, free at 64studio.com wrote:
  >>commit 235549e7080e9d91d1086e9a84840cb8a217d8a8
  >>Author: Free Ekanayaka <free at 64studio.com>
  >>Date:   Sat Dec 20 00:23:54 2008 +0000
  >>
  >>Add lens and test for config files using PHP-style variables,
  >>like /etc/squirrelmail/config.php

  DL> I think this should be split into two modules: one for generic PHP-style
  DL> variables (Phpvars) and one for squirrelmail.

Perfectly fine for me. Just to know it, why would you prefer it split
in two modules? Do you have some scenario in mind where that would be
better?

  DL> Looks good overall, one small nit:

  >>+let eol        = Util.eol
  >>+let indent     = Util.indent
  >>+let empty      = Util.empty
  >>+
  >>+let sep_php    = del /<\?php\n/ "<?php\n"

  DL> Shouldn't this allow at least some whitespace before the \n, i.e.
  DL> 'del /<\?php[ \t]*\n/ "<?php\n"' ?

Sure, that will make it more robust, I'll update the patch.

Ciao!

Free