[augeas-devel] [PATCH] Added rsyncd.conf lens and associated test.

David Lutterkort lutter at redhat.com
Wed Dec 24 01:12:46 UTC 2008


On Tue, 2008-12-23 at 09:17 +0100, Marc Fournier wrote:
> rsyncd.conf is an ini file which allows indented parameters (like smb.conf) as
> well as entries outside any section (like php.ini). This is just a merge of
> bits and pieces taken from these 2 lenses. I would like to thank Raphaël and
> Free for their respective work !

Nice addition. Committed with one tiny change:

> +(************************************************************************
> + *                        RECORD & TITLE
> + * We use IniFile.title_label because there can be entries
> + * outside of sections whose labels would conflict with section names
> + *************************************************************************)
> +let title   = IniFile.title ( IniFile.record_re - /.anon/ )

You actually want 'IniFile.record_re - ".anon"' here, i.e. only exclude
the literal string '.anon', not any 5 letter word that ends with 'anon'
- there was actually a tiny bug in the typechecker that reported a
spurious error withthat change.

I fixed that bug, and committed your lens with the above change.

David





More information about the augeas-devel mailing list