[augeas-devel] Re: [PATCH] Fix empty comments in INI file

[David Lutterkort]

On Fri, 2008-07-25 at 10:54 +0200, raphink at gmail.com wrote:
> # HG changeset patch
> # User Raphael Pinson <raphink at gmail.com>
> # Date 1216976039 -7200
> # Node ID 5f1e98d571c58345b81a247b42cc8a5d5fe07136
> # Parent  26d9cf6f08a155818cab92eb1275a932a017d19b
> Fix empty comments in INI file
> 
> diff -r 26d9cf6f08a1 -r 5f1e98d571c5 lenses/inifile.aug
> --- a/lenses/inifile.aug	Thu Jul 24 17:04:47 2008 +0200
> +++ b/lenses/inifile.aug	Fri Jul 25 10:53:59 2008 +0200
> @@ -10,15 +10,15 @@ module IniFile  =
>      let eol                = del /[ \t]*\n/ "\n"
>      let value_sep          = del /[ \t]*=/ " = "
>      let value_sepwithcolon = del /[ \t]*(=|:)/ " = "
> -    let value_to_eol       = store /([^ \t\n].*[^ \t\n]|[^ \t\n])/
> +    let value_to_eol       = del /[ \t]*/ " " . store /([^ \t\n].*[^ \t\n]|[^ \t\n])/

Are you sure you want the default to be a space instead of the empty
string ? For now, I changed that to 'del /[ \t]*/ ""'

Other than that, ACK and committed.

David