[augeas-devel] [PATCH] Proper typecheck for lens unions

[David Lutterkort]

On Fri, 2008-05-09 at 21:17 -0400, Nate Foster wrote:
> I haven't been following the commit messages all that closely but ...
> only the C's need to be disjoint for the lens laws!

I did that without thinking much - yes, you are right, there shouldn't
be a need for the atype check, though I need to fill in a couple of
FIXME's in put.c when I check whether a skeleton matches the skeleton
type of a lens.

>  (Although
> conditionals of lenses with disjoint branches is probably more
> common... we've even considered having it as the default, and
> requiring that programmers use special syntax for unions of lenses
> with overlapping As just so they realize what they're doing.)

Yeah, that might turn out to be useful in practice; not in any rush to
implement it, though ;)

David