[augeas-devel] [PATCH] Add naturaldocs to doc/

[David Lutterkort]

On Thu, 2008-09-11 at 08:20 +0200, Raphaël Pinson wrote:

> On Thu, Sep 11, 2008 at 3:45 AM, David Lutterkort <lutter at redhat.com>
> wrote:
>         On Wed, 2008-09-10 at 16:12 +0200, Raphael Pinson wrote:
>         > +dnl Check for NaturalDocs
>         > +AC_ARG_WITH([naturaldocs],
>         > +  [AS_HELP_STRING([--with-naturaldocs=DIR],
>         > +    [path to NaturalDocs install dir to generate
>         documentation])],
>         > +  [AC_CHECK_FILE($withval/NaturalDocs,
>         > +      NATURALDOCSDIR=$withval
>         > +      HAS_NATURALDOCS=naturaldocs,
>         > +      [ AC_MSG_ERROR(You asked to use NaturalDocs but it
>         could not be found)])
>         > +  ])
>         > +AC_SUBST(HAS_NATURALDOCS)
>         > +AC_SUBST(NATURALDOCSDIR)
>         
>         
>         I'd prefer it if we could pass the path to the naturaldocs
>         binary/script
>         instead of the dir to the NaturalDocs install - that way, it
>         would also
>         work with a NaturalDocs install from a package (rpm/deb),
>         where you
>         don't really have an install dir.
>         
> 
> Yes, I had tried that before, and for some reason I seemed to need the
> -I$(NDDIR)/Modules. I'll investigate on this since it shouldn't be
> required indeed.

I think the reason it worked for me is because I also have the ND rpm
installed, which puts the ND modules onto the standard Perl path.

>         I'd prefer it if this was something like
>         
>                ifdef HAS_NATURALDOCS
>                  SUBDIRS += naturaldocs
>                endif
>         
>         (or even 'ifdef NATURALDOCSDIR' - we don't need two variables
>         for this)
> 
> I tried this, but automake doesn't use ifdef. 

Yes, you're right - it has to be an if

> Instead, it uses "if" but then you have to declare your variable in
> configure.in, and I didn't want to create configure.in just for this. 

For Augeas, configure.ac is what some docs refer to configure.in, so it
just needs to be declared in configure.in.

> Yes, Menu.txt and created/modified by ND. However, ND renames the old
> Menu.txt into Menu_Backup.txt before doing so, so you can always
> restore the Menu.txt that you had before. I'm not sure about a
> Menu.in, because I think it's ND that has to create/modify the
> Menu.txt anyway. So the normal way of using it should be to run
> "make", modify/fix Menu.txt, run make again, check that the result is
> fine, commit the new Menu.txt and run make clean.

Aah .. ok, that clears it up.

David