[augeas-devel] Re: [PATCH] Add mysql.aug and associated test

[Marc Fournier]

Hello,

I believe the attached patch to Raphaël's mysql lens fixes the problems
mentioned in previous messages.

I'm not sure if this is the exact implementation of what David
suggested in his message of Wed, 03 Sep 2008 21:28:44. But the unit
tests seem to work now and I have successfully been able to
add/edit/remove flag items, key/value items and !include/!includedir
from my my.cnf.

Let me know if something seems wrong. It's my first attempt to modify a
lensfile and I'm not sure to have the full understanding of whe way
things work yet...

Marc

On Thu, Sep 11, 2008 at 06:35:42PM +0200, Raphaël Pinson wrote:
> On Thu, Sep 11, 2008 at 4:51 PM, Marc Fournier
> <marc.fournier at camptocamp.com
> > wrote:
>
> > Hello,
> >
> > I just wanted to draw your attention to the fact mysql also
> > allows this type of records:
> >
> >  !include /path/to/file.cnf
> >
> > I suppose modifying the regex this way should work:
> >
> >  /include(dir)?/
> >
>
>
> Thanks. I was told about it but didn't add it yet. This change should
> do for sure.
>
>
>
> >
> > I'm already trying out mysql.aug with puppet and i'm looking
> > forward to see this lens included in augeas :-)
>
>
> If you have any time to try and fix the double "?" issue, I would be
> really happy to get a patch since I'm not focused on this lens right
> now.
>
>
> Raphaël
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mysql.aug.patch
Type: text/x-patch
Size: 2947 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/augeas-devel/attachments/20080929/e2b6ea51/attachment.bin>