[augeas-devel] Need help with logrotate lens enhancement

[Raphaël Pinson]

On Mon, Sep 29, 2008 at 10:03 PM, Sean E. Millichamp <sean at bruenor.org>wrote:

> On Sun, 2008-09-28 at 20:12 +0200, Raphaël Pinson wrote:
>
> > Thanks for the patch, it looks very nice. I based the initial lens on
> > the options I usually use, so I'm not surprised it's lacking fields.
> > However, list_to_eol is not used as of now. I think it would be
> > actually better to use it instead of defining tabooext separately. So
> > you would have
>
> I apologize if I sounded like I was complaining that there were missing
> fields - I appreciate not having had to start from scratch on it!
>

Not at all. I appreciate that you add to the lens, since I didn't take the
time to go through all these fields.


>
> I suppose I could rework it to work that way, but tabooext is the only
> configuration option that has the special behavior of the leading "+"
> option.  Also, list_to_eol is currently used in the patch by the
> compressoptions option.
>

Yes, I noticed that. In the worst case, it would allow an optional leading
"+" for compressoptions, which will not prevent it to work (it will still
parse the normal compressoptions format properly and won't add "+" to it by
default) but will only not typecheck compressoptions as efficiently (since
it will allow a wrong syntax).



> > It would also be nice to try and limit lines to 80 (or preferably 75)
> > characters and begin to document the code (with NaturalDocs, I might
> > begin to do that for all lenses when I get some time).
>
> I just tried to follow the style that was already in the file.  I didn't
> see any coding styles documented and there were a number of lines
> already longer then 80 characters.
>


Logrotate is one of my first lenses, so that's not very surprising. There a
bit of doc on the wiki about style and documenting. However, don't worry
about that, since I have to go through documenting all the existing lenses
whenever I have time for it.

Thanks for your contrib.


Raphael
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/augeas-devel/attachments/20080930/c5d449dc/attachment.htm>