[augeas-devel] [PATCH] Add xorg.aug and associated test

David Lutterkort lutter at redhat.com
Fri Feb 13 19:43:37 UTC 2009


On Mon, 2009-02-09 at 17:04 +0100, Raphael Pinson wrote:
> From: Raphael Pinson <rpinson at lab64.echo-net.net>
> 
> ---
>  lenses/tests/test_xorg.aug |   38 +++++++++
>  lenses/xorg.aug            |  183 ++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 221 insertions(+), 0 deletions(-)

ACK, just committed that (with some small whitespace/formatting
changes). One question:

> diff --git a/lenses/xorg.aug b/lenses/xorg.aug
> new file mode 100644
> index 0000000..92c0265
> --- /dev/null
> +++ b/lenses/xorg.aug

> +(* Variable: word_space
> + *  TODO: refine possible values by Section
> + *  words with spaces require quotes 
> + *)
> +let word_space  = /"[^"\n]+"/

Does xorg.conf allow escaping " inside these strings, for example can
you have something like "My \"favorite\" Monitor" ? If so, you'd
probably want to sue something like Shellvars.dquot.

David





More information about the augeas-devel mailing list