[augeas-devel] [PATCH] Add missing bison and flex build dependencies

[Matthew Booth]

On 31/07/09 10:38, David Lutterkort wrote:
> On Thu, 2009-07-30 at 18:02 +0100, Matthew Booth wrote:
>> ---
>>   augeas.spec.in |    1 +
>>   1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/augeas.spec.in b/augeas.spec.in
>> index fa97590..206a824 100644
>> --- a/augeas.spec.in
>> +++ b/augeas.spec.in
>> @@ -10,6 +10,7 @@ Source0:        http://augeas.net/download/%{name}-%{version}.tar.gz
>>   BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
>>
>>   BuildRequires:  readline-devel libselinux-devel
>> +BuildRequires:  bison flex
>>   Requires:       %{name}-libs = %{version}-%{release}
>
> Why is this necessary ? The released tarball contains flex- and
> bison-generated files, and should therefore not have a BR on bison/flex
> (in addition, we'd get into hot water with some distros like RHEL4 that
> ship bison/flex versions that are too old)

It's a fair point. Rebuilding the srpm on a machine without bison and 
flex works fine, so they're not required in the spec file.

This came about because I often use a spec file to discover dependencies 
for building a checkout. It seems the two don't necessarily have to 
correspond.

Matt
-- 
Matthew Booth, RHCA, RHCSS
Red Hat Engineering, Virtualisation Team

M:       +44 (0)7977 267231
GPG ID:  D33C3490
GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490