[augeas-devel] [PATCH 2/4] Fix BZ 613967 - memory corruption on reloading externally modified file

[Matthew Booth]

On 05/08/10 21:58, lutter at redhat.com wrote:
> From: David Lutterkort<lutter at redhat.com>
>
> The problem was that when we replaced the old tree for a file with the new
> one we just read from the file, the replace operation did not update
> nodesets in variables, since we did not pass the global symtab into
> tree_replace.
>
>    * src/internal.h (tree_replace): pass in struct augeas, so that we have
>      access to the global symtab
>    * src/augeas.c (tree_replace): make sure we create the pathx with the
>      global symtab
>    * src/transform.c (load_file): adapt to new prototype for tree_replace
>    * tests/test-load.c (testReloadExternalMod): test that we do not segfault
>      when a file was modified externally
> ---
>   src/augeas.c      |    6 +++---
>   src/internal.h    |    2 +-
>   src/transform.c   |    2 +-
>   tests/test-load.c |   52 ++++++++++++++++++++++++++++++++++++++++++++++++++--
>   4 files changed, 55 insertions(+), 7 deletions(-)
>

I've tested this patch and it fixes the V2V crasher. Thanks, David.

Matt
-- 
Matthew Booth, RHCA, RHCSS
Red Hat Engineering, Virtualisation Team

GPG ID:  D33C3490
GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490