[augeas-devel] leanse for corosync.conf and thoughts about packaging lenses

[David Lutterkort]

Hi ANgus,

On Tue, 2010-02-16 at 11:06 +1100, Angus Salkeld wrote:
> Attached is a lens I have written (largely copied from multipath.aug)
> for corosync.conf (see www.corosync.org).
>
> This is the first lenses that I have written so please could you give
> me some review/feedback.

First off, I can barely spell corosync, let alone configure it ;) The
lens and test looks very nice. ACK from me.

> On the augeas web site you suggest keeping the lens with the project.
> I agree this is a good idea, but how do you suggest packaging lenses?

Augeas, by default,  searches two directeries for lenses, in this
order: /usr/share/augeas/lenses and /usr/share/augeas/lenses/dist. The
former is for package-supplied lenses, the latter for lenses that come
with augeas (so that a package can always override a lens supplied with
Augeas)

> For projects that have their own lenses, are they usually installed by
> default or do they have their own rpm (<package>-augeas)?
>
> So for corosync right now the lens will only be used by our test suite
> and will not depend on augeas at all.

You should install it into /usr/share/augeas/lenses - there's no need
for your package to do anything beyond plonk corosync.aug into it, and
put test_corosync.aug into the tests/ subdirectory there.

> Does augeas have a pathing system (some way corosync.rpm can configure
> augeas where the lens is)?

You can add directories to Augeas' search path through the
AUGEAS_LENS_LIB env var and with the -I command line option, though it's
better to just stick it into /usr/share/augeas/lenses.

> Since I have largely copied this from multipath.aug are you happy for me
> to license corosync.aug as BSD (to be consistent with the other corosync
> files)? 

Yes, I am prefectly fine with that. When you have it, can you send me a
link to the lens files ? I need to set something up so that I run tests
against out-of-tree lenses anyway, and I'd like to make sure I don't
break yours in a future release.

David